Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18267 BRS v47: update logKnownIssues #4322

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jan 30, 2025

CLDR-18267

Three tickets were already closed but needed the logKnownIssues adjusted:

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Jan 30, 2025
@srl295 srl295 marked this pull request as ready for review January 30, 2025 00:13
@srl295 srl295 marked this pull request as draft January 30, 2025 01:07
@srl295 srl295 marked this pull request as ready for review January 30, 2025 01:26
@srl295 srl295 marked this pull request as draft January 30, 2025 01:27
@srl295
Copy link
Member Author

srl295 commented Jan 30, 2025

remaining bugs… 

macchiati
macchiati previously approved these changes Jan 30, 2025
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestPaths.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 marked this pull request as ready for review January 30, 2025 16:28
Updated tests to point to the updated tickets:

- CLDR-15663 to CLDR-17857
- CLDR-17756 to CLDR-17945
- CLDR-17544 to CLDR-17849
@srl295 srl295 force-pushed the cldr-18267/brs47/logKnownIssues branch from 94183a1 to 2cc8da8 Compare January 31, 2025 17:33
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested a review from macchiati January 31, 2025 17:33
@srl295
Copy link
Member Author

srl295 commented Jan 31, 2025

sorry, i had garbage in the commit message… copy and paste err

Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wonder if we should update anything in our ticket handling process so that we don't have to update known issue ticket numbers across releases? Maybe resolve in subtasks if we expect the work to stretch across more than one release?

@srl295
Copy link
Member Author

srl295 commented Jan 31, 2025

LGTM!

I wonder if we should update anything in our ticket handling process so that we don't have to update known issue ticket numbers across releases? Maybe resolve in subtasks if we expect the work to stretch across more than one release?

yeah, logKnownIssues predates subtasks — that's might be a good idea to say, always make a subtask for the logKnownIssue. Makes it easier to kick the can down the road- but stops taking time trying to track down this issue.

@srl295 srl295 merged commit fd743e5 into unicode-org:main Jan 31, 2025
12 checks passed
@srl295 srl295 deleted the cldr-18267/brs47/logKnownIssues branch January 31, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants